Merge branch 'pdf-slide-numbers' of https://github.com/dougalsutherland/reveal.js into dev

edit
Hakim El Hattab 2020-01-27 14:10:15 +01:00
commit a59b1415f8
2 changed files with 86 additions and 74 deletions

View File

@ -1017,9 +1017,9 @@ Reveal.configure({ slideNumber: true });
Reveal.configure({ slideNumber: 'c/t' }); Reveal.configure({ slideNumber: 'c/t' });
// You can provide a function to fully customize the number: // You can provide a function to fully customize the number:
Reveal.configure({ slideNumber: function() { Reveal.configure({ slideNumber: function( slide ) {
// Ignore numbering of vertical slides // Ignore numbering of vertical slides
return [ Reveal.getIndices().h ]; return [ Reveal.getIndices( slide ).h ];
}}); }});
// Control which views the slide number displays on using the "showSlideNumber" value: // Control which views the slide number displays on using the "showSlideNumber" value:

View File

@ -77,9 +77,9 @@
// - "c/t": Flattened slide number / total slides // - "c/t": Flattened slide number / total slides
// //
// Alternatively, you can provide a function that returns the slide // Alternatively, you can provide a function that returns the slide
// number for the current slide. The function needs to return an array // number for the current slide. The function should take in a slide
// with one string [slideNumber] or three strings [n1,delimiter,n2]. // object and return an array with one string [slideNumber] or
// See #formatSlideNumber(). // three strings [n1,delimiter,n2]. See #formatSlideNumber().
slideNumber: false, slideNumber: false,
// Can be used to limit the contexts in which the slide number appears // Can be used to limit the contexts in which the slide number appears
@ -855,17 +855,10 @@
// Make sure stretch elements fit on slide // Make sure stretch elements fit on slide
layoutSlideContents( slideWidth, slideHeight ); layoutSlideContents( slideWidth, slideHeight );
// Add each slide's index as attributes on itself, we need these // Compute slide numbers now, before we start duplicating slides
// indices to generate slide numbers below var doingSlideNumbers = config.slideNumber && /all|print/i.test( config.showSlideNumber );
toArray( dom.wrapper.querySelectorAll( HORIZONTAL_SLIDES_SELECTOR ) ).forEach( function( hslide, h ) { toArray( dom.wrapper.querySelectorAll( SLIDES_SELECTOR ) ).forEach( function( slide ) {
hslide.setAttribute( 'data-index-h', h ); slide.setAttribute( 'data-slide-number', getSlideNumber( slide ) );
if( hslide.classList.contains( 'stack' ) ) {
toArray( hslide.querySelectorAll( 'section' ) ).forEach( function( vslide, v ) {
vslide.setAttribute( 'data-index-h', h );
vslide.setAttribute( 'data-index-v', v );
} );
}
} ); } );
// Slide and slide background layout // Slide and slide background layout
@ -936,14 +929,11 @@
} }
// Inject slide numbers if `slideNumbers` are enabled // Inject slide numbers if `slideNumbers` are enabled
if( config.slideNumber && /all|print/i.test( config.showSlideNumber ) ) { if( doingSlideNumbers ) {
var slideNumberH = parseInt( slide.getAttribute( 'data-index-h' ), 10 ) + 1,
slideNumberV = parseInt( slide.getAttribute( 'data-index-v' ), 10 ) + 1;
var numberElement = document.createElement( 'div' ); var numberElement = document.createElement( 'div' );
numberElement.classList.add( 'slide-number' ); numberElement.classList.add( 'slide-number' );
numberElement.classList.add( 'slide-number-pdf' ); numberElement.classList.add( 'slide-number-pdf' );
numberElement.innerHTML = formatSlideNumber( slideNumberH, '.', slideNumberV ); numberElement.innerHTML = slide.getAttribute( 'data-slide-number' );
page.appendChild( numberElement ); page.appendChild( numberElement );
} }
@ -2657,34 +2647,37 @@
} }
/** /**
* Return a hash URL that will resolve to the current slide location. * Return a hash URL that will resolve to the given slide location.
*
* @param {HTMLElement} [slide=currentSlide] The slide to link to
*/ */
function locationHash() { function locationHash( slide ) {
var url = '/'; var url = '/';
// Attempt to create a named link based on the slide's ID // Attempt to create a named link based on the slide's ID
var id = currentSlide ? currentSlide.getAttribute( 'id' ) : null; var s = slide || currentSlide;
var id = s ? s.getAttribute( 'id' ) : null;
if( id ) { if( id ) {
id = encodeURIComponent( id ); id = encodeURIComponent( id );
} }
var indexf; var index = getIndices( slide );
if( config.fragmentInURL ) { if( !config.fragmentInURL ) {
indexf = getIndices().f; index.f = undefined;
} }
// If the current slide has an ID, use that as a named link, // If the current slide has an ID, use that as a named link,
// but we don't support named links with a fragment index // but we don't support named links with a fragment index
if( typeof id === 'string' && id.length && indexf === undefined ) { if( typeof id === 'string' && id.length && index.f === undefined ) {
url = '/' + id; url = '/' + id;
} }
// Otherwise use the /h/v index // Otherwise use the /h/v index
else { else {
var hashIndexBase = config.hashOneBasedIndex ? 1 : 0; var hashIndexBase = config.hashOneBasedIndex ? 1 : 0;
if( indexh > 0 || indexv > 0 || indexf !== undefined ) url += indexh + hashIndexBase; if( index.h > 0 || index.v > 0 || index.f !== undefined ) url += index.h + hashIndexBase;
if( indexv > 0 || indexf !== undefined ) url += '/' + (indexv + hashIndexBase ); if( index.v > 0 || index.f !== undefined ) url += '/' + (index.v + hashIndexBase );
if( indexf !== undefined ) url += '/' + indexf; if( index.f !== undefined ) url += '/' + index.f;
} }
return url; return url;
@ -3428,14 +3421,26 @@
// Update slide number if enabled // Update slide number if enabled
if( config.slideNumber && dom.slideNumber ) { if( config.slideNumber && dom.slideNumber ) {
dom.slideNumber.innerHTML = getSlideNumber();
}
}
/**
* Returns the HTML string corresponding to the current slide number,
* including formatting.
*/
function getSlideNumber( slide ) {
var value; var value;
var format = 'h.v'; var format = 'h.v';
if( slide === undefined ) {
slide = currentSlide;
}
if ( typeof config.slideNumber === 'function' ) { if ( typeof config.slideNumber === 'function' ) {
value = config.slideNumber(); value = config.slideNumber( slide );
} } else {
else {
// Check if a custom number format is available // Check if a custom number format is available
if( typeof config.slideNumber === 'string' ) { if( typeof config.slideNumber === 'string' ) {
format = config.slideNumber; format = config.slideNumber;
@ -3450,23 +3455,21 @@
value = []; value = [];
switch( format ) { switch( format ) {
case 'c': case 'c':
value.push( getSlidePastCount() + 1 ); value.push( getSlidePastCount( slide ) + 1 );
break; break;
case 'c/t': case 'c/t':
value.push( getSlidePastCount() + 1, '/', getTotalSlides() ); value.push( getSlidePastCount( slide ) + 1, '/', getTotalSlides() );
break;
case 'h/v':
value.push( indexh + 1 );
if( isVerticalSlide() ) value.push( '/', indexv + 1 );
break; break;
default: default:
value.push( indexh + 1 ); var indices = getIndices( slide );
if( isVerticalSlide() ) value.push( '.', indexv + 1 ); value.push( indices.h + 1 );
var sep = format === 'h/v' ? '/' : '.';
if( isVerticalSlide( slide ) ) value.push( sep, indices.v + 1 );
} }
} }
dom.slideNumber.innerHTML = formatSlideNumber( value[0], value[1], value[2] ); var url = '#' + locationHash( slide );
} return formatSlideNumber( value[0], value[1], value[2], url );
} }
@ -3477,11 +3480,14 @@
* @param {number} a Current slide * @param {number} a Current slide
* @param {string} delimiter Character to separate slide numbers * @param {string} delimiter Character to separate slide numbers
* @param {(number|*)} b Total slides * @param {(number|*)} b Total slides
* @param {HTMLElement} [url='#'+locationHash()] The url to link to
* @return {string} HTML string fragment * @return {string} HTML string fragment
*/ */
function formatSlideNumber( a, delimiter, b ) { function formatSlideNumber( a, delimiter, b, url ) {
var url = '#' + locationHash(); if( url === undefined ) {
url = '#' + locationHash();
}
if( typeof b === 'number' && !isNaN( b ) ) { if( typeof b === 'number' && !isNaN( b ) ) {
return '<a href="' + url + '">' + return '<a href="' + url + '">' +
'<span class="slide-number-a">'+ a +'</span>' + '<span class="slide-number-a">'+ a +'</span>' +
@ -4232,9 +4238,15 @@
* Returns the number of past slides. This can be used as a global * Returns the number of past slides. This can be used as a global
* flattened index for slides. * flattened index for slides.
* *
* @param {HTMLElement} [slide=currentSlide] The slide we're counting before
*
* @return {number} Past slide count * @return {number} Past slide count
*/ */
function getSlidePastCount() { function getSlidePastCount( slide ) {
if( slide === undefined ) {
slide = currentSlide;
}
var horizontalSlides = toArray( dom.wrapper.querySelectorAll( HORIZONTAL_SLIDES_SELECTOR ) ); var horizontalSlides = toArray( dom.wrapper.querySelectorAll( HORIZONTAL_SLIDES_SELECTOR ) );
@ -4250,7 +4262,7 @@
for( var j = 0; j < verticalSlides.length; j++ ) { for( var j = 0; j < verticalSlides.length; j++ ) {
// Stop as soon as we arrive at the present // Stop as soon as we arrive at the present
if( verticalSlides[j].classList.contains( 'present' ) ) { if( verticalSlides[j] === slide ) {
break mainLoop; break mainLoop;
} }
@ -4259,7 +4271,7 @@
} }
// Stop as soon as we arrive at the present // Stop as soon as we arrive at the present
if( horizontalSlide.classList.contains( 'present' ) ) { if( horizontalSlide === slide ) {
break; break;
} }